[Freeipa-devel] [PATCH] chenxiaolong-001 Use /usr/bin/python2

[Martin Kosek]

On 01/02/2014 02:32 PM, Petr Viktorin wrote:
> On 01/02/2014 01:41 PM, Jan Cholasta wrote:
>> On 2.1.2014 12:37, Petr Viktorin wrote:
...

>>>> instead of hardcoding it?
>>>
>>> - Not all of FreeIPA uses distutils. Of course client-install should
>>> probably start using it, but distutils can't touch Makefiles or the spec
>>> file.
>>
>> That's obvious. We currently run setup.py from the Makefile, not the
>> other way around, and I have no intention of changing that. Some modules
>> are missing setup.py, but that should be easy to fix.
>>
>>> - Having the proper path already available makes development a lot
>>> simpler than having complicated build machinery to call for each change.
>>
>> I'm not against a sane default value.
>>
>>> - To people unfamiliar with this aspect of distutils, it would not be
>>> obvious why/how the hashbang is changed on install. We need less magic
>>> in our build system, not more.
>>
>> This is no more magic than anything else done during build. We already
>> use distutils for some of our script, which means these scripts will
>> have their hashbang changed, while others won't. That's far more
>> confusing than using distutils consistently across all of our scripts.
>>
>>> - Relying on distutils makes FreeIPA tied to our build system, which
>>> other distros may or may not want to reuse.
>>
>> Why would anyone not use our Makefile to build IPA? If there's anything
>> wrong or missing in it, it surely can be fixed. Creating a custom
>> alternative build system does not make sense.
> 
> Fair points.
> If we agree this patch is an improvement, let's start building the bikeshed
> now. We'll get the color right in Beer Exchange.
> 

+1. I would rather like the proposed patch pushed now (as it has immediate
benefit) + have the build improvements filed in a separate ticket for the later
time (Beer Exchange).

Martin