[Freeipa-devel] [PATCH] 0135 resolve SIDs to names in group-show for external members

[Sumit Bose]

On Fri, Jan 17, 2014 at 12:09:03PM +0100, Martin Kosek wrote:
> On 01/17/2014 11:50 AM, Sumit Bose wrote:
> > On Fri, Jan 17, 2014 at 11:49:18AM +0200, Alexander Bokovoy wrote:
> >> On Thu, 16 Jan 2014, Alexander Bokovoy wrote:
> >>> Hi,
> >>>
> >>> when group contains external members, they are specified using SIDs. Use
> >>> trust-resolve command to convert them back on group-show.
> >>>
> >>> https://bugzilla.redhat.com/show_bug.cgi?id=1054391
> >> Sumit found omission on name translation. New patch is attached.
> >>
> >> -- 
> >> / Alexander Bokovoy
> > 
> > Patch now works as expected and python code looks good to me, so ACK.
> > It would be nice if anyone else can check the python code before
> > committing the patch.
> > 
> > bye,
> > Sumit
> 
> Sumit, did you also test Web UI? We should check how it works there, we may no
> longer need to call trust-resolve internally there given it was changed on
> server side.
> 
> If not, Petr1 plans to check that now.

sorry, no, I didn't check it.

bye,
Sumit

> 
> Martin