[Freeipa-devel] [PATCH] 645 webui: display only dialogs which belong to current facet

[Petr Vobornik]

On 10.6.2014 23:11, Endi Sukma Dewata wrote:
> On 5/29/2014 10:15 AM, Petr Vobornik wrote:
>> On 27.5.2014 12:49, Petr Vobornik wrote:
>>> Dialog instances no longer directly call IPA.opened_dialog methods. It's
>>> handled through events (decoupled from dialog's POV). IPA.open_dialogs
>>> with assistance of ApplicationController makes sure that there is only
>>> one dialog opened at the same time.
>>>
>>> It also makes sure to hide all dialogs, which are not global dialogs and
>>> did not originate from current facet, when switching facets.
>>>
>>> https://fedorahosted.org/freeipa/ticket/4348
>>>
>>
>> Attaching rebased version (on top of latest PatternFly patch set).
>
> ACK, but see comments below:

pushed to master with issue #2 
fixed:4b2d20a1f95edd2982fbb1901287f2bb2194c9db

>
> 1. Let's say I had a dialog open and I clicked the button to execute the
> operation but the session expired so I'd get a login screen. Once I
> relogged in, the operation was executed immediately without a chance to
> review the operation. I think it's safer to require the user to reclick
> the button (i.e. the UI ignores the user action that happens while the
> session expired).

+1

This behavior is there for at least 3 years. IMO it worked well with 
just krb auth and login screen in form of a dialog. The behavior is 
especially bad if there are multiple pending actions.

New ticket: https://fedorahosted.org/freeipa/ticket/4374

>
> 2. Can this expression
>
>    !facet || (facet && dialog.facet === facet)
>
> be simplified into this?
>
>    !facet || dialog.facet === facet

yes, fixed

>
> 3. Unrelated. In self-service user page the action menus for Disable,
> Delete, and Rebuild auto membership are enabled although the user
> doesn't have the rights to execute those actions.
>

I'll look at the 'Disable' action but for 'Delete' and 'Rebuild...' we 
don't have enough information. Though, delete could be fixed if we had 
object level rights.
-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0645-2-webui-display-only-dialogs-which-belong-to-current-f.patch
Type: text/x-patch
Size: 8732 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140611/f7b61fb8/attachment.bin>