[Freeipa-devel] [PATCHES] 0591-0593 Change group permission object filter

Petr Viktorin pviktori at redhat.com
Mon Jun 23 08:55:19 UTC 2014


On 06/23/2014 10:01 AM, Martin Kosek wrote:
> On 06/20/2014 02:14 PM, Petr Viktorin wrote:
>> My patch 0580 was wrong; non-POSIX groups obviously lack the posixgroup
>> objectclass. Actually the only objectclasses that all groups share are top and
>> ipaobject.
>>
>> This makes permission plugin & updater join multiple
>> permission_filter_objectclasses filters with OR, and changes the --type group
>> filter to (|(objectclass=ipausergroup)(objectclass=posixgroup)).
>>
>> The first patch has some unrelated test fixes.
>
> This looks as the right thing to do, thanks. Access to group was restored,
> group type also worked fine.
>
> I found just one typo in 593 - "Retreive". When you fix this, it's an ACK.

Thanks for the review!
Typo fixed; pushed to master: ac8539bd344f2309f74efc6b42bddb3a925ff20f


-- 
Petr³




More information about the Freeipa-devel mailing list