[Freeipa-devel] [PATCH 0076] Fix incompatible DNS permission

[Martin Basti]

On Wed, 2014-06-25 at 15:54 +0200, Petr Viktorin wrote:
> On 06/20/2014 03:28 PM, Martin Basti wrote:
> > Patch attached.
> >
> > Ticket:https://fedorahosted.org/freeipa/ticket/4383
> 
> This works, just two comments:
> 
> To check if an entry exists, instead of calling
>      api.Command['permission_show'](permission_name_rel)
> you should call the more light-weight
>      api.Object[permission].get_dn_if_exists(permission_name_rel)
> 
> And for translated messages, use:
>      _('message about %(topic)s") % {...}
> rather than:
>      _('message about %(topic)s" % {...})
> In other words, _() must be called on a literal string. Otherwise it 
> couldn't be looked up in the translation database (or even picked up by 
> gettext).
> 

Thank you for review.
Updated patch attached.
-- 
Martin^2 Basti
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0076-2-Fix-incompatible-DNS-permission.patch
Type: text/x-patch
Size: 2472 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140625/03b1311a/attachment.bin>