[Freeipa-devel] [PATCH] 670-675 webui: dns forward zones

[Endi Sukma Dewata]

On 6/24/2014 9:39 AM, Petr Vobornik wrote:
> On 24.6.2014 13:02, Petr Vobornik wrote:
>> ticket: https://fedorahosted.org/freeipa/ticket/4357
>>
>> - patch 673 is compressed
>> - CI patches functionally depends on #667, #668
>>
>> == PATCH] 670 webui: add confirmation for dns zone permission actions ==
>> All header actions should require confirmation.
>>
>> == [PATCH] 671 webui: dns forward zones ==
>> Add DNS Forward Zones Web UI.
>>
>> - pages under: Identity/DNS/DNS Forward Zones
>>
>> == [PATCH] 672 webui-ci: dns forward zone tests ==
>> Selenium CI sanity tests for DNS Forward Zones
>>
>> == [PATCH] 673 webui-test: static metadata update ==
>> Regular update of static metadata for testing and presentation purposes.
>> It should also contain new DNS Forward Zones metadata.
>>
>> == [PATCH] 674 webui-test: dns forward zone json data ==
>> Fake API results for testing and presentation purposes of DNS Forward
>> Zones.
>>
>> == [PATCH] 675 webui: fix detection of RPC command ==
>> old detection did not work with the static version used for test and
>> demonstration purposes.
>
> Attaching an updated version of #675 with a fix for unit tests.

ACK. Some comments below.

> Btw I'm
> not very satisfied with patch #675's approach. I'm open to suggestions
> for better approaches.

How about adding another parameter to get_record() to indicate the type 
of the data?

Possible improvements:

1. In the Add DNS Forward Zone dialog, if the "Zone forwarders" is empty 
and you click Add, there is no error message.

2. In the same dialog, by default there probably should be an empty 
field to enter the "Zone forwarders" because it's required. The admin 
can click Add to add additional forwarders.

3. The permission name is only displayed briefly after creation. It 
would be nice to display the permission name or a link to it in the 
details page.

4. Unrelated. Should "undo" and "undo all" be capitalized? They seem to 
be inconsistent with other buttons.

-- 
Endi S. Dewata