[Freeipa-devel] [PATCH] 560 webui: rename domNode to dom_node

Petr Vobornik pvoborni at redhat.com
Tue Mar 25 11:49:24 UTC 2014


On 20.3.2014 16:51, Misnyovszki Adam wrote:
> On Wed, 19 Mar 2014 16:02:12 +0100
> Petr Vobornik <pvoborni at redhat.com> wrote:
>
>> - unites domNode and dom_node usage to dom_node
>
> Nack,
>
> install/ui/test/details_tests.js:236
> install/ui/test/details_tests.js:242
>
> only finds element, because context(ie domNode) is undefined, so it
> falls back to html, not the best idea
>
> install/ui/src/freeipa/widgets/App.js:55
>
> not sure if this causes errors, but it's worth renaming for consistency
>
> Greets,
> Adam
>

all fixed, patch attached.
-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0560-1-webui-rename-domNode-to-dom_node.patch
Type: text/x-patch
Size: 10376 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140325/5d842136/attachment.bin>


More information about the Freeipa-devel mailing list