[Freeipa-devel] [PATCH] 561 webui: make navigation module independent on app module

Petr Vobornik pvoborni at redhat.com
Thu Mar 27 11:46:15 UTC 2014


On 26.3.2014 15:36, Misnyovszki Adam wrote:
> On Wed, 19 Mar 2014 16:02:19 +0100
> Petr Vobornik <pvoborni at redhat.com> wrote:
>
>> When some module used 'freeipa/navigation' it pulled the entire Web UI
>> because navigation depended on app.
>>
>> This patch splits the app into two modules: app and app_container.
>> App specifies the entities which are part of final application.
>> app_container module represents the application boot classes.
>> Navigation now depends on app_container.
>
> Hi,
> tests ran as expected, and it works, so
> ACK.
> Note:
> there are two typos in copyright, app.js:5(./),
> app_container.js:1(space before comment), should be corrected before
> push.
> Thanks
> Adam
>

Typos in comments fixed.

Pushed to master: e7bfac1e63360993aea2be91082ca69c478f3cf1
-- 
Petr Vobornik




More information about the Freeipa-devel mailing list