[Freeipa-devel] [PATCH 0239-0243] Refactor ldap_parse_master_zoneentry()

[Petr Spacek]

On 6.5.2014 14:41, Tomas Hozza wrote:
> ----- Original Message -----
>> Hello,
>>
>> This patch set attempts to move ldap_parse_master_zoneentry() a little bit
>> closer to sane code.
>>
>> It is preparation for
>> https://fedorahosted.org/bind-dyndb-ldap/ticket/56
>>
>> --
>> Petr^2 Spacek
>>
>
> Patches look good.
>
> ACK.
>
> ACKing of version 2 of the patch 242 will follow. The patch 243 introduced new compilation
> warning that Peter is aware of. Unfortunately we are unable to find the root cause of it,
> so leaving it as is for now...

I managed to find & fix one problem (see new version of the patch 243) but GCC 
still complains.

../../src/ldap_helper.c: In function 'update_zone':
../../src/ldap_helper.c:2334:34: error: 'data_changed' may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
   if (sync_state == sync_finished && data_changed == ISC_TRUE)
                                   ^
../../src/ldap_helper.c:2218:16: note: 'data_changed' was declared here
   isc_boolean_t data_changed;

On my machine with gcc-4.8.2-7.fc20.x86_64 this happens only with -O2.

I'm not able to reproduce this with clang-3.4-6.fc20.x86_64 but it is no so 
surprising - Clang didn't catch even the first case (fixed by patch version 2).

Any hint what is wrong or how to refactor code will be appreciated! ;-)

-- 
Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bind-dyndb-ldap-pspacek-0243-2-Refactor-zone-apex-synchronization-and-serial-mainte.patch
Type: text/x-patch
Size: 11999 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140506/47e89d5d/attachment.bin>