[Freeipa-devel] [PATCH-0019][Tests]Enabled --auto-reverse by default for master installation

[Martin Basti]

On 21.12.2015 15:02, Martin Basti wrote:
>
>
> On 21.12.2015 11:25, Oleg Fayans wrote:
>> Hi Martin,
>>
>> On 12/19/2015 08:02 PM, Martin Basti wrote:
>>>
>>> On 18.12.2015 09:35, Oleg Fayans wrote:
>>>> Hi Petr,
>>>>
>>>> On 12/17/2015 08:19 PM, Petr Spacek wrote:
>>>>> On 17.12.2015 14:27, Oleg Fayans wrote:
>>>>>> Commit message was updated. Thanks!
>>>>>>
>>>>>> On 12/17/2015 02:05 PM, Lukas Slebodnik wrote:
>>>>>>> On (17/12/15 13:53), Oleg Fayans wrote:
>>>>>>>> -- 
>>>>>>>> Oleg Fayans
>>>>>>>> Quality Engineer
>>>>>>>> FreeIPA team
>>>>>>>> RedHat.
>>>>>>> >From ed4630140386c1043e36733eb42ec402cc276bee Mon Sep 17 00:00:00
>>>>>>> 2001
>>>>>>>> From: Oleg Fayans <ofayans at redhat.com>
>>>>>>>> Date: Thu, 17 Dec 2015 13:50:19 +0100
>>>>>>>> Subject: [PATCH] Enabled automatic creation of reverse zone during
>>>>>>>> master
>>>>>>>> installation
>>>>>>>>
>>>>>>> The commit message does not contain ticket.
>>>>>>> It is also not explained why this change was done.
>>>>>>> Could you update commit message with verbose explanation?
>>>>>>>
>>>>>>> Proper commit message might prevent removal of this change in 
>>>>>>> future
>>>>>>> based on "git blame"
>>>>> Seems reasonable in general but this should not happen in BRQ or
>>>>> ABCDE labs.
>>>>> Where do you see the problem?
>>>>>
>>>>> Otherwise ACK.
>>>> The problem occurs in local libvirt-powered VMs. Also it may (or 
>>>> may not
>>>> - I did not try it yet) be met in Beaker.
>>>>
>>>>
>>> NACK
>>>
>>> ipa-server-install: error: You cannot specify a --auto-reverse option
>>> without the --setup-dns option
>> Agreed. Updated patch is attached.
>>
> ACK
>
> Pushed to:
> master: 36e85b10db7a8671c9116233ab4497ac6410a4a2
> ipa-4-3: 9e3e51d354ff84098952b04ed98af0d93ae129e2
>
Question: shouldn't tasks.dns_install be called with --auto-reverse 
option too?
Martin