[Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

[Oleg Fayans]

Hi Martin,

Thanks for the review!

On 07/08/2016 02:18 PM, Martin Basti wrote:
>
>
> On 27.06.2016 13:53, Oleg Fayans wrote:
>> Hi guys,
>>
>> Is there a chance the patches NN 0047.1 and 0048.1 get reviewed before
>> 4.4 release? They cover a good part of the Managed Topology 4.4 feature.
>>
>> On 06/17/2016 11:18 AM, Oleg Fayans wrote:
>>> One more test was added to the patch-0048
>>>
>>> On 06/17/2016 09:43 AM, Oleg Fayans wrote:
>>>> Fixed a bug in the previous patch, automated 2 more testcases from
>>>> http://www.freeipa.org/page/V4/Manage_replication_topology_4_4/Test_Plan
>>>>
>>>>
>>>> On 06/16/2016 04:46 PM, Oleg Fayans wrote:
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
> IIUC, this will turn off the machine completely, how is cleanup done
> then.  AFAIK our tests cannot turn on machine again and run cleanup, so
> you will not be able to run more tests on the same topology without
> manual cleanup and manual start.
>
> +        replica = self.replicas[0]
> +        replica.run_command(['poweroff'])
>
> IMO would be better to just call 'ipactl stop' instead of 'poweroff'

Agreed! Fixed.

>
> Martin^2
>

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ofayans-0048.2-Automated-ipa-replica-manage-del-tests.patch
Type: text/x-patch
Size: 4775 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160708/0a7984e4/attachment.bin>