[katello-devel] Changeset promotion api/cli in master
Tomas Strachota
tstrachota at redhat.com
Tue Aug 16 08:14:07 UTC 2011
On 25/07/11 15:12, Dmitri Dolguikh wrote:
> On 11-07-25 8:24 AM, Lukas Zapletal wrote:
>>
>> Good work, Tomas.
>>
>>> - new async api route POST
>>> /api/organizations/:org_name/environments/:env_id/changesets/:id/promote
>>
>> Isn't this against the "two-levels-max" rule?
>>
>> I mean this URL could be effortlessly changed to:
>>
>> /environments/:env_id/changesets/:id/promote
>>
>> since the environment id is unique enough. I guess it could be even
>> changed to:
>>
>> /changesets/:id/promote
>>
>> since id is unique too in this case.
>>
>> Objections?
>>
> +1. Was going to write the same, but you beat me to it.
> -d
I created a new shorter route /api/changesets/ for show, destroy, update
and promote. These actions were removed from the former 3-level route
under environments, index & create remain the same (= under
.../environments/id/changesets).
commit 338301f2
T.
More information about the katello-devel
mailing list