[katello-devel] commit reverted for 'cli - new command repo create'
Mike McCune
mmccune at redhat.com
Tue May 24 15:54:37 UTC 2011
On 05/24/2011 08:39 AM, Jason Rist wrote:
> On 05/24/2011 09:25 AM, Lukas Zapletal wrote:
>> On 05/24/2011 05:16 PM, Brad Buckingham wrote:
>>> Please re-merge, verify and push your changes.
>>
>> Hey,
>>
>> let's run unit tests locally prior pushing the changes.
>>
>> The rule is not to rely on Jerkins. He could be sleeping as we can see.
>> And when he is screaming on you it is too late. ;-)
>>
> And at the very least, please run a bit of a sanity check (fire up the
> server, try to navigate around) if you're messing in areas that might
> effect other areas.
>
Here is a simple checklist to refer to if you are asking yourself:
"Should I push this change to master?" :
https://fedorahosted.org/katello/wiki/DevProcess#BeforeyouCommitCodeToMaster
we can add a few things to that table as we see fit.
Mike
--
Mike McCune
mmccune AT redhat.com
Red Hat Engineering | Portland, OR
Systems Management | 650.254.4248
More information about the katello-devel
mailing list