[katello-devel] Activation Keys - Subscriptions - Pools rename

[Bryan Kearney]

On 09/21/2011 06:04 AM, Lukas Zapletal wrote:
> Hello,
>
> we have slight inconsistency between Katello and Candlepin naming
> conventions. If you click on System - Activation Keys - Subscriptions
> you will see list of Entitlement Pools fetched from Candlepin.
>
> While I am perfectly fine with presenting this as Subscriptions to the
> user (I understand entitlements could be confusing), we also use this
> term in the code.


What Katello calls a subscription is an entitlement pool in candlepin.

>
> We have activation_key, kt_subscription and join table as our model
> classes. In the kt_subscription there is a "subscription" column which
> holds entitlement pool uuid. This is subscription vs entitlement pool
> inconsistency. On top of that, as I need to fetch additional pool data
> (and add some lazy loaders to the model class), I do not want to mix
> kt_subscription and pool from Candlepin.
>
> I am renaming our models in the following way:
>
> kt_subscription -> kt_pool
> kt_subscription.subscription -> kt_pool.cp_id
> key_subscription -> key_pool (join table)
>
> Please raise your objections right now, or else...
>
> ps - legend:
>
> subscription - what customer buys from us
> pool - list of available entitlements
> entitlement - what client consumes
>


I an not speak to the model changes.. but the concepts are the same.

-- bk