[katello-devel] Spec failures - help?

[Tom McKay]

It's definitely a bad strategy for our local installs to be looking for anything in /etc, especially when running spec tests. This can lead, as we are seeing, to false results. (One could argue that the failures are true failures and that the missing AppConfig.host should be handled more gracefully.) My suggestion is to rename config/katello.yml to config/katello.yml.example, then have the code look for it first in local config/katello.yml, then in /etc/katello/katello.yml. Any disagreements with that?


----- Original Message -----
> From: "Ivan Nečas" <inecas at redhat.com>
> To: katello-devel at redhat.com
> Sent: Thursday, January 26, 2012 4:52:31 AM
> Subject: Re: [katello-devel] Spec failures - help?
> 
> It looks like AppConfig.host being nil in your config when running
> test
> environment. Might be problem with your katello.yml host config. What
> does your katello.yml look like (both in you repo's config and
> /etc/katello)?
> 
> -- Ivan
> On 01/25/2012 07:26 PM, Jason Rist wrote:
> > Hi All - Getting a few spec failures and it sounds like Thomas is
> > getting the same ones.  Can anyone explain what I'm doing wrong or
> > are
> > these errors lingering from a change?
> > Failures:
> >
> >    1) Product product repos add repo when there is a repo with the
> >    same
> > name for the product should raise conflict error
> >       Failure/Error: @p.add_repo(@repo_name,
> >       "http://test/repo","yum" )
> >       NoMethodError:
> >         You have a nil object when you didn't expect it!
> >         You might have expected an instance of Array.
> >         The error occurred while evaluating nil.+
> >       # ./app/models/glue/pulp/repos.rb:547:in `yum_gpg_key_url'
> >       # ./app/models/glue/pulp/repos.rb:59:in `create_content'
> >       # ./app/models/glue/pulp/repos.rb:356:in `add_repo'
> >       # ./spec/models/product_spec.rb:192
> >
> >    2) RepositoriesController other-tests Test gpg create
> >       Failure/Error: response.should be_success
> >         expected success? to return true, got false
> >       # ./spec/controllers/repositories_controller_spec.rb:98
> >
> > -J
> 
> 
> --
> Regards,
> 
>   Ivan Necas
>   Red Hat Czech s.r.o. Brno
> 
> _______________________________________________
> katello-devel mailing list
> katello-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/katello-devel
>