[katello-devel] Updated Ruby style guide

[Bryan Kearney]

I for one hate checkstyle, and forget to run it. However, if you are 
gonna go through the efforts of having a standard you might as well 
write the tool to check it.

Gee, guess where I land on gun control :)

-- bk


On 11/02/2012 08:32 AM, David Davis wrote:
> I like the idea of setting a suggested limit of characters. In terms of checking though, we can always use pull requests as a guide. In github when viewing a commit, if the line is more than ~120 chars you have to scroll over which is pretty inconvenient and noticeable. It's another reason I think we should limit line length.
>
> David
>
> ----- Original Message -----
>> From: "Petr Chalupa" <pchalupa at redhat.com>
>> To: katello-devel at redhat.com
>> Sent: Friday, November 2, 2012 7:26:29 AM
>> Subject: Re: [katello-devel] Updated Ruby style guide
>>
>> To agree on a limit, let everybody know and follow the rule unless
>> there
>> is a really good reason to broke it (but I cannot think of any in
>> Ruby
>> code).
>>
>> Checker would be nice to let a developer know that he broke the rule,
>> I
>> would also not force it.
>>
>> Petr
>>
>> On 02.11.12 12:17, Lukas Zapletal wrote:
>>> Define "hard limit".
>>>
>>> I have no problems with an agreement, I vote against a checker that
>>> would force us to do it.
>>>
>>> LZ
>>>
>>> On Fri, Nov 02, 2012 at 12:02:46PM +0100, Petr Chalupa wrote:
>>>> I would also support the hard limit at 120 characters, because:
>>>>
>>>> - diff on github is without scrolling
>>>> - 120-chars long lines fitted in any tool I used
>>>> - hard limit is good because then a developer can set his tools to
>>>> that width and do not worry about any line wrapping or left-right
>>>> scrolling
>>>> - it's long enough not to force a developer to split lines too
>>>> often
>>>> - we have much bigger monitors these days :)
>>>>
>>>> On 15.10.12 9:36, Miroslav Suchý wrote:
>>>>> On 10/15/2012 09:22 AM, Lukas Zapletal wrote:
>>>>>> I vote for not giving explicit limit and let it be: use
>>>>>> reasonable line
>>>>>> lengths.
>>>>>
>>>>> In Spacewalk we agreed on limit of 120 characters and I find it
>>>>> as very
>>>>> sane limit.
>>>>>
>>>>
>>>> _______________________________________________
>>>> katello-devel mailing list
>>>> katello-devel at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/katello-devel
>>>
>>
>> _______________________________________________
>> katello-devel mailing list
>> katello-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/katello-devel
>>
>
> _______________________________________________
> katello-devel mailing list
> katello-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/katello-devel
>
>