[katello-devel] Set of checks before pushing

[David Davis]

I probably framed this wrong in my original email but my intent was to learn more about what we're testing or checking and not how or where we should be running these things.

David

----- Original Message -----
> From: "Jeff Weiss" <jweiss at redhat.com>
> To: "David Davis" <daviddavis at redhat.com>
> Cc: "katello-devel" <katello-devel at redhat.com>
> Sent: Monday, November 26, 2012 2:07:54 PM
> Subject: Re: [katello-devel] Set of checks before pushing
> 
> David Davis <daviddavis at redhat.com> writes:
> 
> > Hi all,
> >
> > I'm looking at the DevProcess wiki page
> > (https://fedorahosted.org/katello/wiki/DevProcess) to see what I
> > need
> > to do before opening a pull request and it seems like there are a
> > number of things missing. Can you guys help me fill in any holes?
> > So
> > far I have:
> >
> > - Self code review
> > - Run unit tests
> >   - Run rspec unit tests
> >   - Run minitest tests*
> >   - Run cli (nosetests) unit tests
> > - Functional server
> > - Wrote unit tests?
> > - Run pylint
> > - Run jshint
> > - Update jsroutes
> > - Compile sass/scss files to css
> > - Migrate all the way down then back up
> >
> > * Upcoming
> >
> > I realize that not all of these have to be run every time but I
> > wanted to get a full superset of what the items were.
> >
> > Thanks!
> >
> > David
> >
> > _______________________________________________
> > katello-devel mailing list
> > katello-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/katello-devel
> 
> Shouldn't the CI system (ideally) be running all this for you guys? I
> mean, we're planning to have an automated system to do this, why do
> it
> manually ever?
> 
> I'm not sure how best to accomplish that with github+travis -
> 
> 1) Just submit PR's "blindly" and let travis test it (doesn't seem
> ideal)
> 2) Have travis monitor all branches of the main repo
> 3) Have travis monitor all the devs' forks
> 
> 
> 
> --
> Jeff Weiss
> Principal Quality Assurance Engineer
> jweiss at redhat.com
> (919)886-6533
>