[katello-devel] Set of checks before pushing

[Miroslav Suchý]

On 11/26/2012 07:03 PM, David Davis wrote:
> Hi all,
>
> I'm looking at the DevProcess wiki page (https://fedorahosted.org/katello/wiki/DevProcess) to see what I need to do before opening a pull request and it seems like there are a number of things missing. Can you guys help me fill in any holes? So far I have:
>
> - Self code review
> - Run unit tests
>    - Run rspec unit tests
>    - Run minitest tests*
>    - Run cli (nosetests) unit tests
> - Functional server
> - Wrote unit tests?
> - Run pylint
> - Run jshint
> - Update jsroutes
> - Compile sass/scss files to css
> - Migrate all the way down then back up
>
> * Upcoming
>
> I realize that not all of these have to be run every time but I wanted to get a full superset of what the items were.

Build package - this is MUST item!

And I usually build scratch build in koji and deploy it on Katello on 
production mode, where I do run tests. Because devel deployment is very 
different from production deployment.

-- 
Miroslav Suchy
Red Hat Systems Management Engineering