[katello-devel] Broken build of katello-cli

[David Davis]

Running pylint locally gave me hundreds of warnings which didn't help me to figure out why the build was breaking. Running tito build --test --rpm in the cli directory finally gave me the actual errors. Anyway, I opened a pull request here:

https://github.com/Katello/katello/pull/765

Thanks.

David

----- Original Message -----
From: "Tom McKay" <thomasmckay at redhat.com>
To: "Bryan Kearney" <bkearney at redhat.com>
Cc: katello-devel at redhat.com
Sent: Thursday, September 27, 2012 1:52:49 PM
Subject: Re: [katello-devel] Broken build of katello-cli

I added a story to backlog earlier

----- Original Message -----
> From: "Bryan Kearney" <bkearney at redhat.com>
> To: katello-devel at redhat.com
> Sent: Thursday, September 27, 2012 1:52:19 PM
> Subject: Re: [katello-devel] Broken build of katello-cli
> 
> Should I add a story for a "make check" and "make styish"  like
> subsription-manager? There should be no server side test I can not
> run
> local.
> 
> -- bk
> 
> On 09/27/2012 12:06 PM, Tom McKay wrote:
> > It seems pylint is in the pre-commit testing mix and is mentioned
> > here
> > https://fedorahosted.org/katello/wiki/PythonCodeConventions#CodeStyleChecker
> >
> >
> >
> > ----- Original Message -----
> >> From: "David Davis" <daviddavis at redhat.com>
> >> To: "Miroslav Suchý" <msuchy at redhat.com>
> >> Cc: davidd at scimedsolutions.com, "katello-devel"
> >> <katello-devel at redhat.com>
> >> Sent: Thursday, September 27, 2012 11:52:02 AM
> >> Subject: Re: [katello-devel] Broken build of katello-cli
> >>
> >> I'm running the cli tests locally and everything is passing for me
> >> on
> >> master (http://pastebin.com/1HRrU45x). Is there another set of
> >> tests
> >> I should be running?
> >>
> >>
> >> ----- Original Message -----
> >> From: "Miroslav Suchý" <msuchy at redhat.com>
> >> To: davidd at scimedsolutions.com, "katello-devel"
> >> <katello-devel at redhat.com>
> >> Sent: Thursday, September 27, 2012 11:39:20 AM
> >> Subject: [katello-devel] Broken build of katello-cli
> >>
> >> David,
> >> can you please fix broken build of katello-cli?
> >>
> >> + cd katello-cli-1.1.9
> >> + LANG=C
> >> + export LANG
> >> + unset DISPLAY
> >> + PYTHONPATH=src/
> >> + pylint --rcfile=/etc/spacewalk-pylint.rc --additional-builtins=_
> >> katello
> >> ************* Module katello.client.core.filters
> >> W0311: 91,0: Bad indentation. Found 2 spaces, expected 4
> >> W0311: 93,0: Bad indentation. Found 2 spaces, expected 4
> >> W0311: 94,0: Bad indentation. Found 4 spaces, expected 8
> >> W0311: 95,0: Bad indentation. Found 4 spaces, expected 8
> >> W0311: 97,0: Bad indentation. Found 4 spaces, expected 8
> >> W0311:100,0: Bad indentation. Found 2 spaces, expected 4
> >> W0311:101,0: Bad indentation. Found 4 spaces, expected 8
> >> W0311:103,0: Bad indentation. Found 2 spaces, expected 4
> >> W0311:104,0: Bad indentation. Found 4 spaces, expected 8
> >> W0311:105,0: Bad indentation. Found 4 spaces, expected 8
> >> W0311:106,0: Bad indentation. Found 4 spaces, expected 8
> >> W0311:108,0: Bad indentation. Found 4 spaces, expected 8
> >> W0311:110,0: Bad indentation. Found 4 spaces, expected 8
> >> W0311:111,0: Bad indentation. Found 4 spaces, expected 8
> >> W0622:108,4:Update.run: Redefining built-in 'filter'
> >>
> >> It seems that you were last one who touched filters.py.
> >>
> >> Thanks.
> >>
> >> --
> >> Miroslav Suchy
> >> Red Hat Systems Management Engineering
> >>
> >> _______________________________________________
> >> katello-devel mailing list
> >> katello-devel at redhat.com
> >> https://www.redhat.com/mailman/listinfo/katello-devel
> >>
> >> _______________________________________________
> >> katello-devel mailing list
> >> katello-devel at redhat.com
> >> https://www.redhat.com/mailman/listinfo/katello-devel
> >
> > _______________________________________________
> > katello-devel mailing list
> > katello-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/katello-devel
> >
> 
> _______________________________________________
> katello-devel mailing list
> katello-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/katello-devel

_______________________________________________
katello-devel mailing list
katello-devel at redhat.com
https://www.redhat.com/mailman/listinfo/katello-devel