[katello-devel] Git Clean-up

Eric D Helms ericdhelms at gmail.com
Mon Apr 29 15:56:30 UTC 2013


On Mon, Apr 29, 2013 at 11:12 AM, Miroslav Suchy <msuchy at redhat.com> wrote:

> On 29.4.2013 16:56, Eric Helms wrote:
>
>> On 04/29/2013 10:19 AM, Miroslav Suchy wrote:
>>
>>> On 29.4.2013 15:39, Eric D Helms wrote:
>>>
>>>> deploy/
>>>>
>>>
>>> Here is sysv init scripts. Default configuration for service-wait etc.
>>>
>> Do we use the files from here? I see httpd.conf files and configuration
>> files that I would think now live in the installer. The files in that
>> directory don't appear to have changed for over a year and hence why I
>> am wondering if they are cruft.
>>
>
> Yes, we do. Quote from katello.spec:
> #copy init scripts and sysconfigs
> install -Dp -m0644 %{confdir}/%{name}.sysconfig %{buildroot}%{_sysconfdir}/
> **sysconfig/%{name}
> install -Dp -m0644 %{confdir}/service-wait.**sysconfig
> %{buildroot}%{_sysconfdir}/**sysconfig/service-wait
> install -Dp -m0755 %{confdir}/%{name}.init %{buildroot}%{_initddir}/%{**
> name}
> install -Dp -m0755 %{confdir}/%{name}-jobs.init %{buildroot}%{_initddir}/%{
> **name}-jobs
> install -Dp -m0644 %{confdir}/%{name}.logrotate %{buildroot}%{_sysconfdir}/
> **logrotate.d/%{name}
> install -Dp -m0644 %{confdir}/%{name}.httpd.conf
> %{buildroot}%{_sysconfdir}/**httpd/conf.d/%{name}.conf
> install -Dp -m0644 %{confdir}/thin.yml %{buildroot}%{_sysconfdir}/%{**
> name}/
> install -Dp -m0644 %{confdir}/mapping.yml %{buildroot}%{_sysconfdir}/%{**
> name}/
>
> And some of them are very live. E.g logrotate definition was changed just
> 2 months ago.
>
> Some of them are overwritten by katello-configure (e.g. thin.yml), but
> some of them not (e.g service-wait.sysconfig).
>
> And even those file should be there, because they are are owned by katello
> package.
> And for example katello.httpd.conf just setup error page which state:
>   Katello was not configured yet, please run katello-configure
> and the real httpd.conf is in katello-configure.
>
>
>  etc/
>>>>
>>> Here is what goes into /etc. Currently there is only config file for
>>> katello-service.
>>>
>> Did you look into this directory? There is a single file with four
>> commented out lines and no Katello specific logic.
>>
>
> Yes, I looked into it. And I actually wrote that code/config.
>
> This is config file where you can specify additional services, which
> katello-service should restart - e.g. mongodb or postgresql.
>
> For more details see:
> git show b5ce299b


After some schooling by Justin, I at least better understand what these
are.  And as I explained to him, as someone from a different background and
different view, these 'system level' files were something I would have
expected (and looked for) in katello-configure based on my assumptions of
katello-configures role. But don't worry, I understand (but maybe not
accept fully) the conventions and reasoning behind this.


>
> Mirek
>
> ______________________________**_________________
> katello-devel mailing list
> katello-devel at redhat.com
> https://www.redhat.com/**mailman/listinfo/katello-devel<https://www.redhat.com/mailman/listinfo/katello-devel>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/katello-devel/attachments/20130429/4a73a37c/attachment.htm>


More information about the katello-devel mailing list