[katello-devel] Git Clean-up

[Petr Chalupa]

I would move these directories that are needed only for packaging, under 
a single directory (e.g. rpm or packaging) for root of the repository 
not to be polluted with them.

Petr

On 29.04.13 17:56, Eric D Helms wrote:
>
>
>
> On Mon, Apr 29, 2013 at 11:12 AM, Miroslav Suchy <msuchy at redhat.com
> <mailto:msuchy at redhat.com>> wrote:
>
>     On 29.4.2013 16:56, Eric Helms wrote:
>
>         On 04/29/2013 10:19 AM, Miroslav Suchy wrote:
>
>             On 29.4.2013 15:39, Eric D Helms wrote:
>
>                 deploy/
>
>
>             Here is sysv init scripts. Default configuration for
>             service-wait etc.
>
>         Do we use the files from here? I see httpd.conf files and
>         configuration
>         files that I would think now live in the installer. The files in
>         that
>         directory don't appear to have changed for over a year and hence
>         why I
>         am wondering if they are cruft.
>
>
>     Yes, we do. Quote from katello.spec:
>     #copy init scripts and sysconfigs
>     install -Dp -m0644 %{confdir}/%{name}.sysconfig
>     %{buildroot}%{_sysconfdir}/__sysconfig/%{name}
>     install -Dp -m0644 %{confdir}/service-wait.__sysconfig
>     %{buildroot}%{_sysconfdir}/__sysconfig/service-wait
>     install -Dp -m0755 %{confdir}/%{name}.init
>     %{buildroot}%{_initddir}/%{__name}
>     install -Dp -m0755 %{confdir}/%{name}-jobs.init
>     %{buildroot}%{_initddir}/%{__name}-jobs
>     install -Dp -m0644 %{confdir}/%{name}.logrotate
>     %{buildroot}%{_sysconfdir}/__logrotate.d/%{name}
>     install -Dp -m0644 %{confdir}/%{name}.httpd.conf
>     %{buildroot}%{_sysconfdir}/__httpd/conf.d/%{name}.conf
>     install -Dp -m0644 %{confdir}/thin.yml
>     %{buildroot}%{_sysconfdir}/%{__name}/
>     install -Dp -m0644 %{confdir}/mapping.yml
>     %{buildroot}%{_sysconfdir}/%{__name}/
>
>     And some of them are very live. E.g logrotate definition was changed
>     just 2 months ago.
>
>     Some of them are overwritten by katello-configure (e.g. thin.yml),
>     but some of them not (e.g service-wait.sysconfig).
>
>     And even those file should be there, because they are are owned by
>     katello package.
>     And for example katello.httpd.conf just setup error page which state:
>        Katello was not configured yet, please run katello-configure
>     and the real httpd.conf is in katello-configure.
>
>
>                 etc/
>
>             Here is what goes into /etc. Currently there is only config
>             file for
>             katello-service.
>
>         Did you look into this directory? There is a single file with four
>         commented out lines and no Katello specific logic.
>
>
>     Yes, I looked into it. And I actually wrote that code/config.
>
>     This is config file where you can specify additional services, which
>     katello-service should restart - e.g. mongodb or postgresql.
>
>     For more details see:
>     git show b5ce299b
>
>
> After some schooling by Justin, I at least better understand what these
> are.  And as I explained to him, as someone from a different background
> and different view, these 'system level' files were something I would
> have expected (and looked for) in katello-configure based on my
> assumptions of katello-configures role. But don't worry, I understand
> (but maybe not accept fully) the conventions and reasoning behind this.
>
>
>
>     Mirek
>
>     _________________________________________________
>     katello-devel mailing list
>     katello-devel at redhat.com <mailto:katello-devel at redhat.com>
>     https://www.redhat.com/__mailman/listinfo/katello-devel
>     <https://www.redhat.com/mailman/listinfo/katello-devel>
>
>
>
>
> _______________________________________________
> katello-devel mailing list
> katello-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/katello-devel
>