[katello-devel] Manifest import error handling

[Tom McKay]

----- Original Message -----
> From: "Marek Hulan" <mhulan at redhat.com>
> To: katello-devel at redhat.com
> Sent: Wednesday, January 16, 2013 7:12:37 AM
> Subject: Re: [katello-devel] Manifest import error handling
> 
> On Wednesday 16 of January 2013 09:57:01 Miroslav Suchy wrote:
> > On 16.1.2013 09:08, Marek Hulan wrote:
> > > Hi all
> > > 
> > > I'd like to know you opinion about about changes I'm going to
> > > introduce to
> > > solve a bug related to manifest import [1]. I described a
> > > proposed
> > > solution on wiki [2]. Comments?
> > > 
> > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=790064
> > > [2]
> > > https://fedorahosted.org/katello/wiki/ManifestImportErrorHandlingDesign
> > 
> > I like your proposed solution.
> > 
> > But I do not like the wording. "Refresh" is very generic term and
> > can be
> > confused for e.g. sync.
> > 
> > I would dedicate whole paragraph for this state. Something like:
> > 
> > Some of these products have missing repositories (probably due
> > error
> > during manifest import). You may want to <a>add those missing
> > repositories to products</a>.
> Makes sense to be more descriptive, but to be sure you got me right,
> this link
> would be displayed on subscriptions list page even when no errors
> occurred. We
> do not store information which product encountered an error. And you
> can want
> to do this even when no error occurred.

I'd like to see the error flag persisted since we do indeed know that it happened.

Also, if anything is going to be added to the UI please use that flag to indicate that the 'refresh' is required. For non-error cases, the refresh could be labeled more innocently. 

What are the use cases for wanting to run refresh on non-error products?

> 
> Suppose a new version of product appeared in listing file on CDN.
> Katello
> realizes that after you either run refresh from CLI or cron runs it
> for you.
> You have no way to do this immediately from UI at the moment.
> 
> So I'd change the comment explaining this to something like: "You can
> use
> <a>this link to add missing repositories</a> to products. This can
> happen
> because of errors during manifest import or when CDN contains new
> content."
> 
> Does it make sense?
> 
> --
> Marek
> 
> _______________________________________________
> katello-devel mailing list
> katello-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/katello-devel
>