[Libguestfs] [PATCH libguestfs] build: daemon/do_debug: parameters aren't always unused

Daniel P. Berrange berrange at redhat.com
Mon Aug 10 11:07:13 UTC 2009


On Mon, Aug 10, 2009 at 11:59:21AM +0100, Richard W.M. Jones wrote:
> On Mon, Aug 10, 2009 at 12:47:20PM +0200, Jim Meyering wrote:
> > Thanks to the reminder from Dan Berrange,
> > here's a patch to make build output less verbose, by default.
> > E.g., instead of the redundant multi-line compilation/linking commands,
> > you'll see something like this by default:
> > +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default.
> 
> I tried this one before but it doesn't work on RHEL 5.3:
> 
> aclocal:configure.ac:27: warning: macro `AM_SILENT_RULES' not found in library
> libtoolize: `config.guess' exists: use `--force' to overwrite
> libtoolize: `config.sub' exists: use `--force' to overwrite
> libtoolize: `ltmain.sh' exists: use `--force' to overwrite
> aclocal:configure.ac:27: warning: macro `AM_SILENT_RULES' not found in library
> configure.ac:27: error: possibly undefined macro: AM_SILENT_RULES
>       If this token and others are legitimate, please use m4_pattern_allow.
>       See the Autoconf documentation.
> autoreconf: /usr/bin/autoconf failed with exit status: 1

There's an easy hack to fix that. Just add this to the top of configure.ac

m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])])


that just turns AM_SILENT_RULES into a no-op for places where its not
available.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the Libguestfs mailing list