[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH libguestfs] daemon/ls: make do_ll require root, like all the rest



On Tue, Aug 11, 2009 at 01:17:13PM +0200, Jim Meyering wrote:
[...]

No the comment is unclear.  It should be:

/* Because we can't chroot and run the ls command (since 'ls' won't
 * necessarily exist in the chroot), this command can be used to escape
 * from the sysroot (eg. 'll /..').  This command is not meant for
 * serious use anyway, just for quick interactive sessions.
 *
 * FIXME: eventually, provide a "debug ll" command that would list files
 * in the appliance.
 */

But the rest of the patch is fine, so ACK if the comment is changed.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]