[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH libguestfs 11/23] * src/generator.ml: Change all `String "device"' to `Device "device"'.



On Wed, Aug 12, 2009 at 06:52:47PM +0200, Jim Meyering wrote:
> From: Jim Meyering <meyering redhat com>
> 
> Then update each affected function, removing each uses of RESOLVE_DEVICE,
> now that it's generated in caller from stub.c.
> * daemon/blockdev.c (call_blockdev): Remove use of RESOLVE_DEVICE.
> * daemon/devsparts.c (do_mkfs): Likewise.
> * daemon/ext2.c (do_e2fsck_f, do_get_e2label, do_get_e2uuid): Likewise.
> (do_resize2fs, do_set_e2label, do_set_e2uuid, do_tune2fs_l): Likewise.
> * daemon/fsck.c (do_fsck): Likewise.
> * daemon/grub.c (do_grub_install): Likewise.
> * daemon/lvm.c (do_lvremove, do_pvcreate, do_pvremove): Likewise.
> (do_pvresize): Likewise.
> * daemon/mount.c (do_mount_vfs): Likewise.
> * daemon/ntfs.c (do_ntfs_3g_probe): Likewise.
> * daemon/scrub.c (do_scrub_device): Likewise.
> * daemon/sfdisk.c (sfdisk, sfdisk_flag): Likewise.
> * daemon/swap.c (do_mkswap, do_mkswap_L, do_mkswap_U): Likewise.
> (do_swapoff_device, do_swapon_device): Likewise.
> * daemon/zero.c (do_zero): Likewise.
> * daemon/zerofree.c (do_zerofree): Likewise.
> ---
>  daemon/blockdev.c  |    2 -
>  daemon/devsparts.c |    2 -
>  daemon/ext2.c      |   14 --------
>  daemon/fsck.c      |    2 -
>  daemon/grub.c      |    1 -
>  daemon/lvm.c       |    8 -----
>  daemon/mount.c     |    2 -
>  daemon/ntfs.c      |    2 -
>  daemon/scrub.c     |    2 -
>  daemon/sfdisk.c    |    4 --
>  daemon/swap.c      |   10 ------
>  daemon/zero.c      |    2 -
>  daemon/zerofree.c  |    2 -
>  src/generator.ml   |   86 ++++++++++++++++++++++++++--------------------------
>  14 files changed, 43 insertions(+), 96 deletions(-)

Yes, this is all good.  ACK.

At the end of this patch series, someone needs to go through the list
of calls in the generator and make sure all the parameters are
correct.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]