[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH libguestfs 14/23] generator.ml: emit "const char *" for Device and String params



On Wed, Aug 12, 2009 at 06:52:50PM +0200, Jim Meyering wrote:
> From: Jim Meyering <meyering redhat com>
> 
> * src/generator.ml: Emit "const char *", not "char *" for Device and
> String params, now that the non-const code is hoisted into the calling
> code in stubs.c.
> ---
>  src/generator.ml |   12 +++++-------
>  1 files changed, 5 insertions(+), 7 deletions(-)
[..]

> @@ -6774,6 +6771,7 @@ DESTROY (g)
>        iteri (
>          fun i ->
>            function
> +	  (* FIXME: ? *)
>            | Device n | String n | FileIn n | FileOut n -> pr "      char *%s;\n" n
>            | OptString n ->
>                (* http://www.perlmonks.org/?node_id=554277
> -- 
> 1.6.4.337.g5420e

Whether this is correct depends on the global typemap.

Anyway, ACK.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]