[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCHx7] Misc patches



Richard W.M. Jones wrote:
>>From 9beb53ca567147aa2cd03c8e68b11706bc284713 Mon Sep 17 00:00:00 2001
> From: Richard Jones <rjones trick home annexia org>
> Date: Thu, 13 Aug 2009 14:37:43 +0100
> Subject: [PATCH 1/7] do_equal does not need to explicitly check for NEED_ROOT/ABS_PATH.
>
> ---
>  daemon/cmp.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/daemon/cmp.c b/daemon/cmp.c
> index 56717c5..2b7e33b 100644
> --- a/daemon/cmp.c
> +++ b/daemon/cmp.c
> @@ -34,10 +34,6 @@ do_equal (const char *file1, const char *file2)
>    char *err;
>    int r;
>
> -  NEED_ROOT (return -1);
> -  ABS_PATH (file1, return -1);
> -  ABS_PATH (file2, return -1);

Right.  Now that each arg is of type "Pathname" in generator.ml,
those tests are redundant.

ACK


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]