[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH libguestfs] build: avoid "make sytnax-check" failure



Richard W.M. Jones wrote:
> On Fri, Aug 14, 2009 at 09:05:01PM +0200, Jim Meyering wrote:
>> FYI, just pushed:
>
> Thanks.
>
> Sorry, I have 'make check' in my head, but not 'make syntax-check',

No problem.

> which is why I seem to be adding tab characters.
>
> Is there any reason why we wouldn't add the following to Makefile.am?
>
>   check:: syntax-check
>
> Or failing that can we add it to HACKING?

Either works.  Your call.

I think of a "make check" failure as fundamentally more serious,
while the syntax-check tests are more in a "would-be-nice" vein.
Personally, I don't lose sleep if "make syntax-check" is broken for
a few days, and perhaps its better that those rules don't distract too much.
However, I do make sure that "make distcheck" (which covers both) always
succeeds around release time.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]