[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] [PATCH virt-v2v] make most of "make distcheck" pass



Hi Matt,

You need to "git add" Makefile.PL.in to the repo.
Once you do that, and apply the following patch,
most of "make distcheck" will work.

The only remaining failure seems to be that these
files are not removed by "make uninstall":

  ERROR: files left after uninstall:
  ./lib64/perl5/5.10.0/x86_64-linux-thread-multi/perllocal.pod
  ./lib64/perl5/site_perl/5.10.0/x86_64-linux-thread-multi/auto/virtv2v/.packlist

which I haven't investigated yet.

>From 7d8369f1191e5c9ef3a7f3c977eb25e046c2ad1a Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering redhat com>
Date: Thu, 20 Aug 2009 17:01:08 +0200
Subject: [PATCH] make most of "make distcheck" pass

---
 configure.ac    |    1 +
 v2v/Makefile.am |    6 +++++-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index aa5c665..3e057d7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -78,6 +78,7 @@ fi

 AC_CONFIG_FILES([Makefile
                  perl/Makefile
+                 perl/Makefile.PL
                  v2v/Makefile
                  po/Makefile.in])
 AC_OUTPUT
diff --git a/v2v/Makefile.am b/v2v/Makefile.am
index 65ac778..49dac50 100644
--- a/v2v/Makefile.am
+++ b/v2v/Makefile.am
@@ -41,4 +41,8 @@ virt-v2v.1: virt-v2v.pl

 install-data-hook:
 	mkdir -p $(DESTDIR)$(bindir)
-	install -m 0755 virt-v2v.pl $(DESTDIR)$(bindir)/virt-v2v
+	install -m 0755 $(srcdir)/virt-v2v.pl $(DESTDIR)$(bindir)/virt-v2v
+
+uninstall-hook:
+	rm -f $(DESTDIR)$(bindir)/virt-v2v
+	-rmdir $(DESTDIR)$(bindir)
--
1.6.4.378.g88f2f


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]