[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH libguestfs 8/9] generator.ml: avoid signed/unsigned-comparison warning in fish/cmds.c



On Fri, Aug 21, 2009 at 03:28:18PM +0200, Jim Meyering wrote:
> From: Jim Meyering <meyering redhat com>
> 
> * src/generator.ml (emit_print_list_function): Emit code that doesn't
> evoke warnings.  s/int/unsigned int/
> (emit print_*_indent): Likewise, s/int/unsigned int/
> ---
>  src/generator.ml |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/generator.ml b/src/generator.ml
> index a371ffd..46fcf2c 100755
> --- a/src/generator.ml
> +++ b/src/generator.ml
> @@ -6109,7 +6109,7 @@ and generate_fish_cmds () =
>      pr "static void print_%s_list (struct guestfs_%s_list *%ss)\n"
>        typ typ typ;
>      pr "{\n";
> -    pr "  int i;\n";
> +    pr "  unsigned int i;\n";
>      pr "\n";
>      pr "  for (i = 0; i < %ss->len; ++i) {\n" typ;
>      pr "    printf (\"[%%d] = {\\n\", i);\n";
> @@ -6129,7 +6129,7 @@ and generate_fish_cmds () =
>        pr "static void print_%s_indent (struct guestfs_%s *%s, const char *indent)\n" typ typ typ;
>        pr "{\n";
>        if needs_i then (
> -        pr "  int i;\n";
> +        pr "  unsigned int i;\n";
>          pr "\n"
>        );
>        List.iter (
> -- 
> 1.6.4.378.g88f2f
> 
> _______________________________________________
> Libguestfs mailing list
> Libguestfs redhat com
> https://www.redhat.com/mailman/listinfo/libguestfs

ACK.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]