[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH libguestfs 3/5] guestfish: don't try to diagnose getopt failure



On Mon, Aug 24, 2009 at 12:21:55PM +0200, Jim Meyering wrote:
> From: Jim Meyering <meyering redhat com>
> 
> * fish/fish.c: ... getopt_long already does that.  Instead, suggest
> "Try `guestfish --help' for more information."
> ---
>  fish/fish.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fish/fish.c b/fish/fish.c
> index 8ea1c49..964c906 100644
> --- a/fish/fish.c
> +++ b/fish/fish.c
> @@ -320,8 +320,6 @@ main (int argc, char *argv[])
>        usage (0);
> 
>      default:
> -      fprintf (stderr, _("%s: unexpected command line option 0x%x\n"),
> -               program_name, c);
>        usage (1);
>      }
>    }
> -- 
> 1.6.4.378.g88f2f

If the previous patch is fixed, then this looks good - ACK.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]