[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] build: fix test for --nocompress option



Richard W.M. Jones wrote:
> On Wed, Jul 29, 2009 at 10:50:44PM +0200, Jim Meyering wrote:
>> The test for febootstrap-to-initramfs' --nocompress option
>> was always failing for me on F11.  Here's why:
> [...]
>
> Ouch that's obscure.  I've applied this patch and the previous
> one you sent too.  Thanks!

Our messages crossed.
Rebasing my fixed patch and adjusting the log:


>From 9e7846da50ceeee57187f703835bd3975e789719 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering redhat com>
Date: Wed, 29 Jul 2009 16:33:02 -0400
Subject: [PATCH] build: quote the other option test similarly

* configure.ac: Quote properly.
---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 6bdf7d4..20edc70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -248,7 +248,7 @@ if test "x$enable_supermin" = "xyes"; then
     AC_MSG_CHECKING([for --files support in $FEBOOTSTRAP_TO_INITRAMFS])
     out=`$FEBOOTSTRAP_TO_INITRAMFS 2>&1 ||:`
     echo "febootstrap_to_initramfs test command output: $out" >&AS_MESSAGE_LOG_FD
-    if ! echo $out | grep -sq -- "--files" ; then
+    if ! echo "$out" | grep -sq -e --files ; then
         AC_MSG_RESULT([no])
 	AC_MSG_FAILURE(
 [febootstrap-to-initramfs does not support the --files option.
--
1.6.3.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]