[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] hivex.c: unchecked calloc



On Tue, Nov 03, 2009 at 06:44:27PM +0100, Jim Meyering wrote:
> Hi Rich,
> 
> There's an unchecked calloc in hivex.c's hive_open:
> 
>   h->bitmap = calloc (1 + h->size / 32, 1);
>   ...
> This subsequent deref could cause a segfault:
> 
>         BITMAP_SET (h->bitmap, blkoff);

Thanks - I pushed this to fix it:

http://git.et.redhat.com/?p=libguestfs.git;a=commitdiff;h=f95c697a44c321dd1d370620515aa71a71a4ad5b

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]