[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] Fix dependencies on generator.ml



Matthew Booth wrote:
> This change adds an explicit dependency on generator.ml for every file it
> generates, except java files. Java is left for another time because it's
> considerably trickier.
>
> This fixes parallel make, and will automatically re-create generated files when
> make is run from any directory.
>
> It also changes the contents of the distribution tarball by including files
> created by rpcgen.
>
> It also fixes the problem which efad4f53 was targetting. Specifically,
> src/guestfs_protocol.(c|h) had an erroneous dependency on stamp-generator, and
> therefore generator.ml, despite not being directly created by it. This caused
> them to be recreated every time generator.ml ran rather than only when
> src/guestfs_protocol.x was updated, which cascaded into a daemon and therefore
> appliance update.

ACK.
I confirm that the only difference from the version I tested
is this Makefile variable name change: s/GENERATOR_ML/generator_built/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]