[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH libguestfs] maint: remove unnecessary include of openat.h



On Fri, Nov 20, 2009 at 12:42:44PM +0100, Jim Meyering wrote:
> Richard W.M. Jones wrote:
> > On Fri, Nov 20, 2009 at 11:51:20AM +0100, Jim Meyering wrote:
> >> >From 34af5f3be8b04443dc151e6d070aa49cbe59b7fc Mon Sep 17 00:00:00 2001
> >> From: Jim Meyering <meyering redhat com>
> >> Date: Fri, 20 Nov 2009 11:50:54 +0100
> >> Subject: [PATCH libguestfs] maint: remove unnecessary include of openat.h
> >>
> >> * daemon/realpath.c: Don't include "openat.h".  not used.
> >> ---
> >>  daemon/realpath.c |    2 --
> >>  1 files changed, 0 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/daemon/realpath.c b/daemon/realpath.c
> >> index 17e74ea..750cadb 100644
> >> --- a/daemon/realpath.c
> >> +++ b/daemon/realpath.c
> >> @@ -27,8 +27,6 @@
> >>  #include <sys/types.h>
> >>  #include <dirent.h>
> >>
> >> -#include "openat.h"
> >> -
> >>  #include "daemon.h"
> >>  #include "actions.h"
> 
> With the latest standard-conforming headers, (and gnulib
> provides that), openat is declared in fcntl.h, so openat.h
> really is not required.  Assuming you're using gnulib's fcntl module,
> which guarantees a conforming <fcntl.h> at worst, via lib/fcntl.h.

OK - I'll push this later.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]