[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] fix new failures from latest-from-gnulib syntax-check



On Fri, Nov 20, 2009 at 12:22:19PM +0100, Jim Meyering wrote:
> There's a new syntax check rule from gnulib.
> It requires that you write e.g., exit (EXIT_SUCCESS), not exit (0).
> And the same for 1/EXIT_FAILURE and any other constants.

Was there ever a platform where 0/1 weren't used for success or
failure?  IIRC OS-9 was one such platform, but that was an indication
of fail in OS-9.

Anyway, I will push these patches shortly, with the exception of this
hunk:

  @@ -10056,7 +10056,7 @@ public class Bindtests {
           }
           catch (Exception exn) {
               System.err.println (exn);
  -            System.exit (1);
  +            System.exit (EXIT_FAILURE);
           }
       }
   }

Rich.

PS. http://coccinelle.lip6.fr/ is great for these sorts of semantic
transformations.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]