[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH VERSION 2] daemon/Win32: use gnulib modules connect, socket and symlinkat (for readlinkat).



On Thu, Nov 26, 2009 at 02:57:04PM +0100, Jim Meyering wrote:
> Richard W.M. Jones wrote:
> > +  if (winsock_init () == -1) {
> > +    fprintf (stderr, "winsock initialization failed\n");
> 
> It would be nice to include strerror info.
> (as long as you're using gnulib's error module, might as well use it;
> added advantage: this diagnostic is now inconsistent with all others
> in that it prints the customary "program_name: " prefix)
> 
>     error (0, 0, "winsock initialization failed");

OK, I'll make this change when I push it.

Actually, first parameter will be EXIT_FAILURE ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]