[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 0/9] FOR DISCUSSION ONLY: daemon error handling



On Fri, Nov 27, 2009 at 06:01:56PM +0000, Richard W.M. Jones wrote:
> The more I look at this patch, the less I like it.

But I think some patches in this set do make sense to apply anyway:

[PATCH 1/9] daemon error handling: Formalize access to errno.

- I think the idea of formalizing access to errno, and in particular
  not having code that saves and restores errno, is a good one.

[PATCH 5/9] daemon error handling: fix case_sensitive_path for Windows.

- This is really a separate issue and I think we should just apply
  this one.

[PATCH 6/9] daemon error handling: clear errors before all functions

- Clearing errno before invoking stub functions seems like a
  reasonable change to me.  It can avoid incorrect error messages in
  cases where error handling paths that aren't tested very much are
  wrong, for virtually no cost.

[PATCH 7/9] daemon error handling: recursive_mkdir shouldn't need to
set errno.

- This one is basically a cleanup, it avoids setting errno in order to
  communicate an error to the local caller, and I think we should
  apply it.

[PATCH 8/9] daemon error handling: Change CHROOT_* macros handling of
errno.

- Chroot handling in general needs fixing for Win32, but I didn't like
  the way the macros save and restore errno, and so I think this
  change makes sense on its own.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]