[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/5] Move virt tools (virt-cat, virt-edit etc) into tools/ subdirectory.



On Mon, Oct 19, 2009 at 04:55:51PM +0100, Matthew Booth wrote:
> -         --title 'virt-edit, edit a file in a virtual machine' \
>           --htmldir html \
> -         --outfile html/virt-edit.1.html \
> -         edit/$<
> +         --outfile html/$<.1.html \
> +         tools/$<
> ---
>
> You lost the title in the html documentation. Not a huge deal, I guess,  
> but still a regression.

No actually I checked the HTML here and it's fine - it still includes
the all-important title.

I used to work in SEO you know :-)

> -exec('perl', $path.'/rescue/virt-rescue', @ARGV);
> +print (join " ", ("$path/tools/virt-$tool", @ARGV), "\n");
> +exec('perl', "$path/tools/virt-$tool", @ARGV);
> ---
>
> The print looks like debug output. Did you intend to leave it in there?

I did actually intend to leave it there, but it might be
better to remove it on consideration.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]