[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] Re: [PATCH] GuestOS::RedHat: Fix internationalisation bug



On 03/09/09 09:20, Matthew Booth wrote:
---
  perl/lib/Sys/VirtV2V/GuestOS/RedHat.pm |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/perl/lib/Sys/VirtV2V/GuestOS/RedHat.pm b/perl/lib/Sys/VirtV2V/GuestOS/RedHat.pm
index 87a30c7..3d85c99 100644
--- a/perl/lib/Sys/VirtV2V/GuestOS/RedHat.pm
+++ b/perl/lib/Sys/VirtV2V/GuestOS/RedHat.pm
@@ -165,7 +165,8 @@ sub _init_selinux

          if($@) {
              print STDERR "virt-v2v: ".
-                         __"WARNING unable to configure SELinux: "."$!\n";
+                         _x("WARNING unable to configure SELinux: {error})",
+                            error =>  $!)."\n";
          }
      }
  }

Um... sorry. Forgot --compose there.

I should have sent this patch with the other patch. This fixes the internationalisation issue. Of course, I only found it once xgettext was working ;) As for trailing blanks, I'm going to have to come up with something for that.

There's actually a bigger issue with this Makefile, which is that it doesn't install .mo files into the regular place. I believe where it installs them works with libintl-perl, but as I don't have any other .mo files on my system in a LocaleData directory, I'm inclined to change it.

However, it's still nice and simple, and easy to change. I'll make the install location customisation and submit the change upstream.

Matt
--
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]