[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] generator.ml: Fix string list memory leak



On Fri, Sep 11, 2009 at 10:56:57AM +0100, Matthew Booth wrote:
> +      (* XXX: There must be a cleaner way to write this *)
> +      iteri (
> +        fun i ->
> +            function
[...]
> +      ) (snd style);

Another thing - strange use of iteri here.

Just use List.iter, as in:

List.iter (
  function
  | ...
) (snd style);

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]