[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] guestfish: Enable grouping in string lists



On Fri, Sep 11, 2009 at 05:54:44PM +0100, Matthew Booth wrote:
> +      tok = realloc (tok, tok_len + 1);
> +      if (NULL == tok) { perror ("realloc"); exit (1); }

As before, this leaves tok allocated on the error path.

[...]

Inclusion of documentation is good, but this patch still needs
comprehensive tests.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]