[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] guestfish: Enable grouping in string lists



On 12/09/09 11:06, Richard W.M. Jones wrote:
On Fri, Sep 11, 2009 at 05:54:44PM +0100, Matthew Booth wrote:
+      tok = realloc (tok, tok_len + 1);
+      if (NULL == tok) { perror ("realloc"); exit (1); }

As before, this leaves tok allocated on the error path.

As discussed on IRC, although this strictly isn't necessary here because of the exit(), I'll add this anyway for robustness in case the exit is changed later.


[...]

Inclusion of documentation is good, but this patch still needs
comprehensive tests.

New patch coming up includes comprehensive tests.

Matt
--
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]