[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] Remove explicit guestfs=10.0.2.4:6666 kernel command line parameter.



On Thu, Sep 17, 2009 at 04:44:11PM +0200, Jim Meyering wrote:
> All looks good, though this seems like it *is* a functional
> change, since it removes the -h and -p options below.

Ah yes, you're right.  Removing these is OK I think because no one
would ever have used them, and they are not used by the appliance init
script.

> Two questions:
> 
> First, note the definition of GUESTFWD_ADDR above
> Why the commented-out one below (in src/guestfs.c):
> 
>   //#define GUESTFWD_ADDR "10.0.2.4"

This is just commented out because it isn't used, and gcc now gives a
warning when we define but don't use a macro.

> Second, I saw this in the context:
> 
> >    /* Make sure SIGPIPE doesn't kill us. */
> >    memset (&sa, 0, sizeof sa);
> >    sa.sa_handler = SIG_IGN;
> 
> Have you considered alternate ways of ignoring SIGPIPE?
> Ignoringn SIGPIPE across the board can cause problems (albeit subtle)
> in unsuspecting child processes.

I didn't know there were alternate ways to ignore SIGPIPE.  Can you
give some examples of how it should be done?  (Possibly in a new
thread -- seems a separate issue from the patch at hand).

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 75 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]