[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] Fix verbose packet dumping functions.



On Thu, Sep 17, 2009 at 04:52:33PM +0200, Jim Meyering wrote:
> Looks fine.
> You might want to change that "#if 0" to something like
> "#if LIBGUESTFS_ENABLE_PACKET_DUMP" so that you can enable it
> without modifying the code.  Then there'd be less risk of accidentally
> committing a change that was required solely for debugging.

Good idea - I pushed a variation on this theme:

http://git.et.redhat.com/?p=libguestfs.git;a=commitdiff;h=bb02f0fbe80ef093731bc9a6a407f1edaccf991d

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]