[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] hivex: Makefiles not fully cleaning up?



I'm currently creating a Debian/Ubuntu package for hivex.

In the process I noticed that several files that are created during the
build process are left behind after a 'clean'.

I'm currently using the attached patch but wondered if this is something
that should be adopted, or have I misunderstood something?


Description: Add Makefile rules to Clean all built files
Author: TJ <debian tjworld net>

diff --git a/Makefile.am b/Makefile.am
index 112cce0..b8b980f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -65,3 +65,5 @@ WEBSITEDIR = $(HOME)/d/redhat/websites/libguestfs
 
 website: $(HTMLFILES)
 	cp $(HTMLFILES) $(WEBSITEDIR)
+
+CLEANFILES = $(HTMLFILES) pod2*.tmp
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 16d7107..75db8bf 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -55,3 +55,5 @@ $(top_builddir)/html/hivex.3.html: hivex.pod
 	  --htmldir html \
 	  --outfile html/hivex.3.html \
 	  lib/hivex.pod
+
+CLEANFILES = $(man_MANS)
diff --git a/perl/Makefile.am b/perl/Makefile.am
index 26e25cd..ddc40b7 100644
--- a/perl/Makefile.am
+++ b/perl/Makefile.am
@@ -53,7 +53,7 @@ Makefile-pl: Makefile.PL
 
 clean-local:
 	-$(MAKE) -f Makefile-pl clean
-	rm -f Makefile-pl
+	rm -f Makefile-pl Makefile-pl.old
 
 install-data-hook:
 	$(MAKE) -f Makefile-pl DESTDIR=$(DESTDIR) install
diff --git a/regedit/Makefile.am b/regedit/Makefile.am
index ab286cd..4353ee8 100644
--- a/regedit/Makefile.am
+++ b/regedit/Makefile.am
@@ -41,3 +41,5 @@ $(top_builddir)/html/hivexregedit.1.html: hivexregedit
 	  --htmldir html \
 	  --outfile html/hivexregedit.1.html \
 	  regedit/hivexregedit
+
+CLEANFILES = $(man_MANS)
diff --git a/sh/Makefile.am b/sh/Makefile.am
index e085b3d..a3ca5c7 100644
--- a/sh/Makefile.am
+++ b/sh/Makefile.am
@@ -79,3 +79,5 @@ $(top_builddir)/html/hivexsh.1.html: hivexsh.pod
 	  --htmldir html \
 	  --outfile html/hivexsh.1.html \
 	  sh/hivexsh.pod
+
+CLEANFILES = $(man_MANS)
diff --git a/xml/Makefile.am b/xml/Makefile.am
index 4d4b56b..b2af45d 100644
--- a/xml/Makefile.am
+++ b/xml/Makefile.am
@@ -51,3 +51,5 @@ $(top_builddir)/html/hivexml.1.html: hivexml.pod
 	  --htmldir html \
 	  --outfile html/hivexml.1.html \
 	  xml/hivexml.pod
+
+CLEANFILES = $(man_MANS)
diff --git a/images/Makefile.am b/images/Makefile.am
index b9f9619..2808aa5 100644
--- a/images/Makefile.am
+++ b/images/Makefile.am
@@ -31,3 +31,6 @@ noinst_DATA = large
 
 large: mklarge
 	./mklarge $(srcdir)/minimal large
+
+CLEANFILES = $(noinst_DATA)
+

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]