[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] Fix virt-v2v exit codes



On 26/04/10 14:44, Jim Meyering wrote:
> Matthew Booth wrote:
>> If something die()s, the error status can get lost in cleanup when various
>> child processes exit and overwrite $?. Specifically, the RHEV target uses a
>> child process for NFS access, and libguestfs launches a qemu child process.
>>
>> This change ensures that DESTROY and END blocks which perform operations on
>> child processes explicitly preserve $?.
> 
> Hi Matt,
> Those change look fine to me.

Thanks, both. Pushed with extra comments.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]