[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/3] Call sync after guestfsd exits



On Tue, Aug 17, 2010 at 01:29:05PM +0100, Matthew Booth wrote:
> On 17/08/10 12:49, Richard W.M. Jones wrote:
> >On Tue, Aug 03, 2010 at 05:20:12PM +0100, Matthew Booth wrote:
> >>  sync
> >>  sleep 1
> >>  sync
> >
> >Definitely can't have a sleep here.  What's wrong with a single
> >'sync'?  It is documented that it doesn't return until all outstanding
> >writes have been committed to disk.
> 
> I was actually just keeping the code that was already there. I did
> think it was a bit odd.
> 
> I can remove this.

Oh I see.  This is for the virt-rescue case, so it should do
into the else branch.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]