[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 8/8] Converter: Remove obsolete xen-specific configuration



On 04/02/10 09:54, Richard W.M. Jones wrote:
> On Mon, Feb 01, 2010 at 05:23:36PM +0000, Matthew Booth wrote:
>> Don't update /domain/@type just for xen as it's always set explicitly to kvm.
>> Don't update /domain/devices/input/@bus as it's replaced by a default device.
> 
> Not sure I understand the explanation for this, but the code
> looks OK, so ACK.

I used to have some code in there which said:

if /domain/@type == xen
  replace it with the default value

Now I just unconditionally replace it with the default value. Same for
the input device.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]