[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 7/12] Tools for analyzing and reverse engineering hive files.



On 03/02/10 18:33, Richard W.M. Jones wrote:
> Subject: [PATCH 07/12] Tools for analyzing and reverse engineering hive files.
> 
> This commit is not of general interest.  It contains the tools which
> I used to reverse engineer the hive format and to test changes.
> Keeping these with the rest of the code is useful in case in future
> we encounter a hive file that we fail to modify.
> 
> Note that the tools are not compiled by default.  You have to compile
> each explicitly with:
> 
>   make -C hivex/tools <toolname>.opt
> ---
>  .gitignore                        |    1 +
>  configure.ac                      |    1 +
>  hivex/Makefile.am                 |    2 +
>  hivex/tools/Makefile.am           |   54 +++
>  hivex/tools/clearheaderfields.ml  |  112 +++++
>  hivex/tools/fillemptyhbins.ml     |   74 ++++
>  hivex/tools/truncatefile.ml       |  112 +++++
>  hivex/tools/visualizer.ml         |  845 +++++++++++++++++++++++++++++++++++++
>  hivex/tools/visualizer_NT_time.ml |   30 ++
>  hivex/tools/visualizer_utils.ml   |  160 +++++++
>  10 files changed, 1391 insertions(+), 0 deletions(-)
>  create mode 100644 hivex/tools/Makefile.am
>  create mode 100644 hivex/tools/clearheaderfields.ml
>  create mode 100644 hivex/tools/fillemptyhbins.ml
>  create mode 100644 hivex/tools/truncatefile.ml
>  create mode 100644 hivex/tools/visualizer.ml
>  create mode 100644 hivex/tools/visualizer_NT_time.ml
>  create mode 100644 hivex/tools/visualizer_utils.ml

Ok, I haven't looked at the contents, but agree that keeping them around
is useful. The only bits which might break anything are the build changes.

Have you confirmed that this genuinely does nothing during a normal
build? I note you've included tools as a SUBDIR in hivex/Makefile.am
which, as I understand it, will cause make to be executed with the same
target as the parent directory on every invocation. Does 'make' without
arguments genuinely do nothing in that directory? I vaguely recall that
it will default to building the first target, which would be
visualizer.opt here.

It might be better not to specify tools as a SUBDIR in hivex/Makefile.am.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]